Skip to content

Conversation

shulaoda
Copy link
Collaborator

Summary

          LGTM. You could also replace name `RealDependencyRange` with `DependencyRange` and remove `ErrorSpan`. Both of them looks good to me.

Originally posted by @h-a-n-a in #7892 (comment)

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@shulaoda shulaoda marked this pull request as draft September 19, 2024 15:36
Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1539a18
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66f18d1931fe8000080d8432

@shulaoda shulaoda force-pushed the refactor/dependency-location branch from 278d8c9 to 1539a18 Compare September 23, 2024 15:45
@shulaoda shulaoda closed this Nov 1, 2024
@shulaoda shulaoda deleted the refactor/dependency-location branch November 1, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant